ENH Remove background form description and unclickable fields #1652
Conversation
client/src/components/Form/Form.scss
Outdated
| @@ -147,7 +147,8 @@ | |||
| .form__field-holder p.readonly, | |||
| .form__field-holder input.readonly, | |||
| .form__field-holder span.readonly, | |||
| .readonly .form__field-holder > div { | |||
| .readonly .form__field-holder > div:not(.form__field-description) { | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
| pointer-events: none; |
I'm don't think we should be setting this to none in the context of this PR, because I really don't know what all the possible scenarios are, and I don't even know if it's desirable. I did a quick search for this and a couple of comments here were negative about setting this to none
Somewhat related I've raised a new card to handle ->setDisabled(true); and when a TextField is disabled it has no mouse-pointer, though when it's readonly it does have a mouse pointer.
If we're going to remove the mouse-pointer from all readonly form fields in the CMS then it should really be done in a separate issue, not one that's specifically for linkfield
sabina-talipova
force-pushed
the
pulls/2.1/enhance-readonly-fields
branch
from
9b9cb2a to
3d4ff89
Compare
client/src/components/Form/Form.scss
Outdated
| @@ -161,6 +161,10 @@ | |||
| border-color: $input-focus-border-color; | |||
| outline: none; | |||
| } | |||
|
|
|||
| &:hover { | |||
| cursor: not-allowed; | |||
There was a problem hiding this comment.
This shouldn't be the cursor state. It implies they're doing something wrong by mousing over it, though they may just want to select the text so they can copy-paste it which is perfectly fine.
sabina-talipova
force-pushed
the
pulls/2.1/enhance-readonly-fields
branch
from
3d4ff89 to
1c6f96b
Compare
sabina-talipova
force-pushed
the
pulls/2.1/enhance-readonly-fields
branch
from
1c6f96b to
bedad80
Compare
Description
.form__field-descriptionfrom list to exclude styles.Before:
After:
